Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] TypeScript #226

Merged
merged 10 commits into from
Jan 2, 2025
Merged

[Feature] TypeScript #226

merged 10 commits into from
Jan 2, 2025

Conversation

titouanmathis
Copy link
Collaborator

@titouanmathis titouanmathis commented Jan 2, 2025

πŸ”— Linked issue

#107

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add types.

To-do

  • Fix types

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

netlify bot commented Jan 2, 2025

βœ… Deploy Preview for vue-mapbox-gl-demo ready!

Name Link
πŸ”¨ Latest commit
πŸ” Latest deploy log https://app.netlify.com/sites/vue-mapbox-gl-demo/deploys/6776e7c2e0d3f39868e16e3f
😎 Deploy Preview https://deploy-preview-226--vue-mapbox-gl-demo.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 2, 2025

Export Size

@studiometa/vue-mapbox-gl

Name Size Diff
StoreLocator 5.44 kB -1.64 kB (-23.18%) πŸ”½
MapboxMap 2.06 kB -1.33 kB (-39.24%) πŸ”½
MapboxMarker 1.67 kB -1.75 kB (-51.23%) πŸ”½
MapboxGeocoder 1.57 kB -1.7 kB (-51.99%) πŸ”½
MapboxGeolocateControl 1.34 kB -1.8 kB (-57.27%) πŸ”½
MapboxCluster 1.8 kB -2.43 kB (-57.54%) πŸ”½
MapboxPopup 1.25 kB -1.8 kB (-58.96%) πŸ”½
MapboxNavigationControl 1.2 kB -1.98 kB (-62.33%) πŸ”½
MapboxFullscreenControl 1.15 kB -2 kB (-63.43%) πŸ”½
useControl 1.02 kB -2.03 kB (-66.46%) πŸ”½
MapboxLayer 973 B -2.31 kB (-70.34%) πŸ”½
MapboxImages 888 B -2.75 kB (-75.58%) πŸ”½
MapboxImage 665 B -2.72 kB (-80.34%) πŸ”½
useEventsBinding 551 B -2.5 kB (-81.92%) πŸ”½
VueScroller 634 B -2.9 kB (-82.07%) πŸ”½
usePropsBinding 439 B -2.61 kB (-85.58%) πŸ”½
MapboxSource 437 B -2.8 kB (-86.50%) πŸ”½
useMap 166 B -2.88 kB (-94.55%) πŸ”½

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.85%. Comparing base (79e02b9) to head (21a8b9c).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
packages/vue-mapbox-gl/composables/useMap.ts 28.57% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
- Coverage    88.34%   86.85%   -1.49%     
===========================================
  Files           22       22              
  Lines         1827     1453     -374     
  Branches        11       11              
===========================================
- Hits          1614     1262     -352     
+ Misses         213      191      -22     
Flag Coverage Ξ”
unittests 86.85% <90.56%> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@titouanmathis titouanmathis merged commit 69bc344 into develop Jan 2, 2025
9 of 14 checks passed
@titouanmathis titouanmathis deleted the feature/typescript branch January 2, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant