Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log nats url credentials #911

Merged

Conversation

Adphi
Copy link
Contributor

@Adphi Adphi commented Jan 28, 2025

No description provided.

natsclient.go Outdated Show resolved Hide resolved
@Adphi Adphi force-pushed the do-not-leak-nats-credentials branch from cdcb539 to 471469f Compare January 28, 2025 13:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13011009361

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 63.944%

Changes Missing Coverage Covered Lines Changed/Added Lines %
natsclient.go 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
grpc_remote_client.go 2 75.57%
client.go 5 73.99%
Totals Coverage Status
Change from base Build 13010958487: -0.005%
Covered Lines: 11886
Relevant Lines: 18588

💛 - Coveralls

@fancycode fancycode merged commit b719a56 into strukturag:master Jan 28, 2025
17 of 19 checks passed
@fancycode
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants