Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing codec parameters when creating publishers. #853

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

fancycode
Copy link
Member

Finally implements #79

@fancycode fancycode linked an issue Oct 31, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11664327301

Details

  • 84 of 175 (48.0%) changed or added relevant lines in 9 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 59.824%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mcu_janus_remote_publisher.go 0 1 0.0%
mcu_janus_remote_subscriber.go 0 1 0.0%
mcu_common.go 24 27 88.89%
mcu_janus_publisher.go 0 5 0.0%
mcu_janus_subscriber.go 0 5 0.0%
mcu_proxy.go 38 56 67.86%
mcu_janus.go 0 58 0.0%
Files with Coverage Reduction New Missed Lines %
client.go 2 74.86%
mcu_proxy.go 2 60.57%
Totals Coverage Status
Change from base Build 11654694528: 0.3%
Covered Lines: 11013
Relevant Lines: 18409

💛 - Coveralls

@fancycode fancycode merged commit 47abaa1 into master Nov 4, 2024
25 of 26 checks passed
@fancycode fancycode deleted the codec-config branch November 4, 2024 12:51
fancycode added a commit that referenced this pull request Nov 4, 2024
This was missing before, so add as follow-up to #853.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability to configure supported codecs and profiles
2 participants