Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: Close client connection if session is expired / closed. #852

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

fancycode
Copy link
Member

This handles cases where during development the machine is suspended and on resume, the session is expired but the connection is still open. As for the expired session the internal context is closed, the session can no longer be used.

This handles cases where during development the machine is suspended and
on resume, the session is expired but the connection is still open. As
for the expired session the internal context is closed, the session can
no longer be used.
@fancycode fancycode force-pushed the proxy-close-conn-expired-session branch from 9d3c526 to 4dd2bba Compare October 31, 2024 12:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11612410282

Details

  • 13 of 15 (86.67%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.08%) to 59.578%

Changes Missing Coverage Covered Lines Changed/Added Lines %
proxy/proxy_session.go 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
proxy/proxy_client.go 2 84.0%
client.go 2 73.41%
grpc_remote_client.go 2 75.57%
dns_monitor.go 3 95.93%
Totals Coverage Status
Change from base Build 11611939759: 0.08%
Covered Lines: 10938
Relevant Lines: 18359

💛 - Coveralls

@fancycode fancycode merged commit 81e9d8d into master Oct 31, 2024
22 of 23 checks passed
fancycode added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants