-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CONTRIBUTING.md file #1515
Conversation
added contribution guidelines link to README
added section on maintaining compatibility with older platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! some little brevity comments you can take or leave, but I like it.
Also, since nothing in this file is especially ruby-specific, we could have a single copy of it in codegen and copy it over as part of generation. Might need to do some light find-and-replace for the language name to link to issues correctly, but I don't think that's too bad. It'll save us from having to update any typos/changes manually 7 times!
I love this idea. I was actually thinking of how to do this, and maintaining a template in codegen that gets copied over as part of generation makes a lot of sense! |
clarified language about generated code Co-authored-by: Ramya Rao <[email protected]>
incorporated review feedback
Why?
Introduce guidelines and tips on how to contribute in order to better enable our development community to make contributions to the SDK.
What?