Measure usage of .save #1293
Merged
Measure usage of .save #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-usage
branch
from
ebbef6b to
aa26c78
Compare
Co-authored-by: anniel-stripe <[email protected]>
|
Could use a re-review after Omit usage if empty. |
anniel-stripe
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
.saveinX-Stripe-Client-Telemetry. (You can disable telemetry viaStripe.enable_telemetry = false, see the README.)Details
I've added
usagepositionally to the end of several methods inRequest(used as a mix-in on api resource classes). It has a default, so this change is non-breaking. I was tempted to add it as a keyword argument instead, but opted to be consistent withparamsandopts. I also added it toStripeClientas a keyword argument, also consistent withparamsandopts.Testing
I modified the existing test case for telemetry to use a method that would trigger "save" usage to be included.