Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom bank account flow #192

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

calvind-stripe
Copy link
Contributor

@calvind-stripe calvind-stripe commented Oct 28, 2024

now that disable_stripe_user_authentication is GA - remove the custom bank account form and the redirect to it at the end of onboarding.

Instead, set disable_stripe_user_authentication to true for Custom accounts and don't specify external_account_collection. Since the latter defaults to true, for Custom accounts we will start collecting bank account info in onboarding without requiring auth.

For all other account types, external_account_collection defaults to true anyways, so bank account info will continue to be collected. And other account types can't disable stripe auth so it's safe to set disable_stripe_user_authentication=false for them.

I tested with custom accounts (to make sure auth is disabled and bank account form is shown) and all other account types (to ensure the POST to v1/account_sessions did not error).

Screen.Recording.2024-10-28.at.5.06.06.PM.mov
Screen.Recording.2024-10-28.at.5.06.06.PM.mov

@calvind-stripe calvind-stripe merged commit e498481 into master Oct 28, 2024
2 checks passed
@calvind-stripe calvind-stripe deleted the calvind-disable-stripe-auth branch October 28, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants