Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that
disable_stripe_user_authentication
is GA - remove the custom bank account form and the redirect to it at the end of onboarding.Instead, set
disable_stripe_user_authentication
totrue
for Custom accounts and don't specifyexternal_account_collection
. Since the latter defaults totrue
, for Custom accounts we will start collecting bank account info in onboarding without requiring auth.For all other account types,
external_account_collection
defaults totrue
anyways, so bank account info will continue to be collected. And other account types can't disable stripe auth so it's safe to setdisable_stripe_user_authentication=false
for them.I tested with custom accounts (to make sure auth is disabled and bank account form is shown) and all other account types (to ensure the
POST
tov1/account_sessions
did not error).Screen.Recording.2024-10-28.at.5.06.06.PM.mov
Screen.Recording.2024-10-28.at.5.06.06.PM.mov