-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play Integrity Playground #9926
base: master
Are you sure you want to change the base?
Conversation
Diffuse output:
APK
|
cloudProjectNumber = 577365562050, // stripe-payments-sdk-prod | ||
logError = { message, error -> | ||
Logger.getInstance(com.stripe.attestation.BuildConfig.DEBUG).error(message, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a secret key
val usedNativeContract = intent?.getBooleanExtra(EXTRA_USED_NATIVE_CONTRACT, false) ?: false | ||
return if (usedNativeContract) { | ||
nativeLinkActivityContract.parseResult(resultCode, intent) | ||
} else { | ||
webLinkActivityContract.parseResult(resultCode, intent) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering reverting to a createLinkActivityResult
to avoid this logic. I would add it to a LinkIntentParser
.
Another way to do this is to check if
val redirectUri = intent?.data
if (redirectUri != null) {
// use web
} else {
// use native
}
This is probably the easiest solution and allows me to keep the parsing logic in its own contract.
a87ae60
to
3845367
Compare
Summary
Open
NativeLink
config.useAttestationEndpointsForLink
, prepareintegrityManager
integrityManager
preparation fails, move toWebLink
v1/consumers/mobile
) (not part of this PR)NativeLink
without attestation (v1/consumers/*
) (only relevant in test mode)This PR has a consumer service that can be shared. We would need to swap out the calls to
linkAccountManager
during sign upMotivation
Testing
Screenshots
simulating play attestation preparation failure
Screen.Recording.2025-01-16.at.7.05.08.PM.mov
Changelog