bug: fix sink retain ordering and ignore custom runtime options server set vals #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
| Description: resourceFunctionDescriptions[resourceFunctionSubscriptionPositionKey], | ||
| ValidateFunc: func(val interface{}, key string) ([]string, []error) { |
There was a problem hiding this comment.
Seems can use a common method for functions/sins both
| @@ -327,19 +351,19 @@ func resourcePulsarFunction() *schema.Resource { | |||
| resourceFunctionCPUKey: { | |||
| Type: schema.TypeFloat, | |||
| Optional: true, | |||
| Default: 0.5, | |||
| Computed: true, | |||
There was a problem hiding this comment.
why the default value is removed?
There was a problem hiding this comment.
the resources will be returned by worker service apis and it may changed by the worker service, so it should be marked as computed to prevent the resources been frequently update.
jiangpengcheng
approved these changes
Jan 12, 2024
maxsxu
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
computed, because the resources configs may changed by the worker service and we should use the returned value to the state.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)