Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace unbounded channel with bounded #312

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

cirias
Copy link
Contributor

@cirias cirias commented May 24, 2024

This is the follow-up of #311 and #310

  1. Use a bounded channel for the outbound message queue. This size of the channel can be configured with method with_outbount_channel_size of the client builder.
  2. A new ConnectionError SlowDown is introduced. This error is returned when the internal message queue for sending is full.

@cirias cirias force-pushed the feature/bounded-channel branch from 02e8ff6 to f6660b8 Compare May 24, 2024 07:12
@cirias cirias force-pushed the feature/bounded-channel branch from f6660b8 to a2be7fe Compare May 24, 2024 07:22
@BewareMyPower BewareMyPower merged commit 918c25a into streamnative:master Jun 5, 2024
5 checks passed
FlorentinDUBOIS added a commit to FlorentinDUBOIS/pulsar-rs that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants