chore(*): enable revive.flag-parameter rules #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsytj0413
requested review from
merlimat,
mattisonchao,
coderzc and
RobertIndie
as code owners
cmd/client/put/cmd.go
Outdated
| return nil, ErrBase64ValueInvalid | ||
| } | ||
| return decoded, nil | ||
| func convertBinaryValue(value string) ([]byte, error) { |
There was a problem hiding this comment.
convertToBinary or convertTo ?
Because convert binary value looks like we want to convert a binary to other type. :)
There was a problem hiding this comment.
rename to convertFromBinaryValue，because when this is called, the value is an Binary base64 format.
lsytj0413
force-pushed
the
add-revive-flag-parameter
branch
from
e1b18e0 to
3fd9445
Compare
Signed-off-by: Soren Yang <[email protected]>
lsytj0413
force-pushed
the
add-revive-flag-parameter
branch
from
3fd9445 to
75b918e
Compare
merlimat
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.