chore(*): enable gosec/godot linter

.golangci.yaml

@@ -36,9 +36,9 @@ linters:
     - errorlint
     - exportloopref
     # - gocritic
-    # - godot
+    - godot
     # - gomoddirectives
-    # - gosec
+    - gosec
     - nakedret
     - nilerr
     - nilnil
@@ -79,4 +79,5 @@ issues:
   exclude-rules:
     - path: _test\.go
       linters:
-        - unparam
+        - unparam
+        - gosec

common/metrics/metrics.go

@@ -21,6 +21,7 @@ import (
 	"net"
 	"net/http"
 	"os"
+	"time"
 
 	"github.com/pkg/errors"
 	"github.com/prometheus/client_golang/prometheus/promhttp"
@@ -100,8 +101,11 @@ func Start(bindAddress string) (*PrometheusMetrics, error) {
 	}
 
 	p := &PrometheusMetrics{
-		server: &http.Server{Handler: mux},
-		port:   listener.Addr().(*net.TCPAddr).Port,
+		server: &http.Server{
+			Handler:           mux,
+			ReadHeaderTimeout: time.Second,
+		},
+		port: listener.Addr().(*net.TCPAddr).Port,
 	}
 
 	slog.Info(fmt.Sprintf("Serving Prometheus metrics at http://localhost:%d/metrics", p.port))

common/pprof.go

@@ -20,9 +20,10 @@ import (
 	"io"
 	"log/slog"
 	"net/http"
-	_ "net/http/pprof"
+	_ "net/http/pprof" //nolint:gosec
 	"os"
 	"runtime/pprof"
+	"time"
 )
 
 var (
@@ -48,8 +49,9 @@ func DoWithLabels(labels map[string]string, f func()) {
 
 func RunProfiling() io.Closer {
 	s := &http.Server{
-		Addr:    PprofBindAddress,
-		Handler: http.DefaultServeMux,
+		Addr:              PprofBindAddress,
+		Handler:           http.DefaultServeMux,
+		ReadHeaderTimeout: time.Second,
 	}
 
 	if !PprofEnable {

coordinator/impl/metadata_file.go

@@ -113,7 +113,7 @@ func (m *metadataProviderFile) Store(cs *model.ClusterStatus, expectedVersion Ve
 		return "", err
 	}
 
-	if err := os.WriteFile(m.path, newContent, 0640); err != nil {
+	if err := os.WriteFile(m.path, newContent, 0600); err != nil {
 		return MetadataNotExists, err
 	}
 

coordinator/impl/shard_controller.go

@@ -563,7 +563,7 @@ func (s *shardController) selectNewLeader(newTermResponses map[model.ServerAddre
 	}
 
 	// Select a random leader among the nodes with the highest entry in the wal
-	leader = candidates[rand.Intn(len(candidates))]
+	leader = candidates[rand.Intn(len(candidates))] //nolint:gosec
 	followers = make(map[model.ServerAddress]*proto.EntryId)
 	for a, e := range newTermResponses {
 		if a != leader {

oxia/async_client_impl.go

@@ -212,10 +212,10 @@ func (c *clientImpl) List(ctx context.Context, minKeyInclusive string, maxKeyExc
 	ch := make(chan ListResult)
 	wg := common.NewWaitGroup(len(shardIds))
 	for _, shardId := range shardIds {
-		shardIdPtr := &shardId
+		shardIdPtr := shardId
 		go func() {
 			request := &proto.ListRequest{
-				ShardId:        shardIdPtr,
+				ShardId:        &shardIdPtr,
 				StartInclusive: minKeyInclusive,
 				EndExclusive:   maxKeyExclusive,
 			}

perf/perf.go

@@ -153,7 +153,7 @@ func (p *perf) generateWriteTraffic(ctx context.Context, client oxia.AsyncClient
 			return
 		}
 
-		key := p.keys[rand.Intn(int(p.config.KeysCardinality))]
+		key := p.keys[rand.Intn(int(p.config.KeysCardinality))] //nolint:gosec
 
 		start := time.Now()
 		ch := client.Put(key, value)
@@ -188,7 +188,7 @@ func (p *perf) generateReadTraffic(ctx context.Context, client oxia.AsyncClient,
 			return
 		}
 
-		key := p.keys[rand.Intn(int(p.config.KeysCardinality))]
+		key := p.keys[rand.Intn(int(p.config.KeysCardinality))] //nolint:gosec
 
 		start := time.Now()
 		ch := client.Get(key)