-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(*): enable revive.cyclomatic rules (#409)
Signed-off-by: Soren Yang <[email protected]>
- Loading branch information
Showing
11 changed files
with
191 additions
and
114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright 2023 StreamNative, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package kv | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "log/slog" | ||
| "os" | ||
| ) | ||
|
|
||
| // pebbleLogger is the wrapper of slog to implement pebbel's logger interface. | ||
| type pebbleLogger struct { | ||
| zl *slog.Logger | ||
| } | ||
|
|
||
| func (pl *pebbleLogger) Infof(format string, args ...any) { | ||
| pl.zl.Info( | ||
| fmt.Sprintf(format, args...), | ||
| ) | ||
| } | ||
|
|
||
| func (pl *pebbleLogger) Errorf(format string, args ...any) { | ||
| pl.zl.Error( | ||
| fmt.Sprintf(format, args...), | ||
| ) | ||
| } | ||
|
|
||
| func (pl *pebbleLogger) Fatalf(format string, args ...any) { | ||
| pl.zl.Warn( | ||
| fmt.Sprintf(format, args...), | ||
| ) | ||
| os.Exit(1) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| // Copyright 2023 StreamNative, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package kv | ||
|
|
||
| import ( | ||
| "bytes" | ||
| ) | ||
|
|
||
| func compareWithSlash(a, b []byte) int { | ||
| for len(a) > 0 && len(b) > 0 { | ||
| idxA, idxB := bytes.IndexByte(a, '/'), bytes.IndexByte(b, '/') | ||
| switch { | ||
| case idxA < 0 && idxB < 0: | ||
| return bytes.Compare(a, b) | ||
| case idxA < 0 && idxB >= 0: | ||
| return -1 | ||
| case idxA >= 0 && idxB < 0: | ||
| return +1 | ||
| } | ||
|
|
||
| // At this point, both slices have '/' | ||
| spanA, spanB := a[:idxA], b[:idxB] | ||
| spanRes := bytes.Compare(spanA, spanB) | ||
| if spanRes != 0 { | ||
| return spanRes | ||
| } | ||
|
|
||
| a, b = a[idxA+1:], b[idxB+1:] | ||
| } | ||
|
|
||
| switch { | ||
| case len(a) < len(b): | ||
| return -1 | ||
| case len(a) > len(b): | ||
| return +1 | ||
| } | ||
|
|
||
| return 0 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Copyright 2023 StreamNative, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package kv | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "testing" | ||
| ) | ||
|
|
||
| var benchKeyA = []byte("/test/aaaaaaaaaaa/bbbbbbbbbbb/cccccccccccc/dddddddddddddd") | ||
| var benchKeyB = []byte("/test/aaaaaaaaaaa/bbbbbbbbbbb/ccccccccccccddddddddddddddd") | ||
|
|
||
| func Benchmark_StandardCompare(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| bytes.Compare(benchKeyA, benchKeyB) | ||
| } | ||
| } | ||
|
|
||
| func Benchmark_CompareWithSlash(b *testing.B) { | ||
| for i := 0; i < b.N; i++ { | ||
| compareWithSlash(benchKeyA, benchKeyB) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright 2023 StreamNative, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package kv | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestCompareWithSlash(t *testing.T) { | ||
| assert.Equal(t, 0, compareWithSlash([]byte("aaaaa"), []byte("aaaaa"))) | ||
| assert.Equal(t, -1, compareWithSlash([]byte("aaaaa"), []byte("zzzzz"))) | ||
| assert.Equal(t, +1, compareWithSlash([]byte("bbbbb"), []byte("aaaaa"))) | ||
|
|
||
| assert.Equal(t, +1, compareWithSlash([]byte("aaaaa"), []byte(""))) | ||
| assert.Equal(t, -1, compareWithSlash([]byte(""), []byte("aaaaaa"))) | ||
| assert.Equal(t, 0, compareWithSlash([]byte(""), []byte(""))) | ||
|
|
||
| assert.Equal(t, -1, compareWithSlash([]byte("aaaaa"), []byte("aaaaaaaaaaa"))) | ||
| assert.Equal(t, +1, compareWithSlash([]byte("aaaaaaaaaaa"), []byte("aaa"))) | ||
|
|
||
| assert.Equal(t, -1, compareWithSlash([]byte("a"), []byte("/"))) | ||
| assert.Equal(t, +1, compareWithSlash([]byte("/"), []byte("a"))) | ||
|
|
||
| assert.Equal(t, -1, compareWithSlash([]byte("/aaaa"), []byte("/bbbbb"))) | ||
| assert.Equal(t, -1, compareWithSlash([]byte("/aaaa"), []byte("/aa/a"))) | ||
| assert.Equal(t, -1, compareWithSlash([]byte("/aaaa/a"), []byte("/aaaa/b"))) | ||
| assert.Equal(t, +1, compareWithSlash([]byte("/aaaa/a/a"), []byte("/bbbbbbbbbb"))) | ||
| assert.Equal(t, +1, compareWithSlash([]byte("/aaaa/a/a"), []byte("/aaaa/bbbbbbbbbb"))) | ||
|
|
||
| assert.Equal(t, +1, compareWithSlash([]byte("/a/b/a/a/a"), []byte("/a/b/a/b"))) | ||
| } |
Oops, something went wrong.