Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 hotfix: broken clip page and generate thumbnails repeated requests #847

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

greatsamist
Copy link
Contributor

😵 Post-Mortem 😵

Summary

  1. Broken Clip Page: An added if statement caused the page to return "not found" when previewId was missing or undefined.
  2. Multiple Thumbnail Requests: The page was making multiple requests to generate thumbnails for sessions, resulting in unnecessary network calls and potential performance issues.

Impact

  • Services Affected: Broken Clip page
  • User Impact: Users no longer have access to the clip page

Root Cause Analysis

Issue 1: Broken Clip Page

An if statement was added to the Clip page, causing it to return a "not found" page when previewId was missing in the search params or when the previewAsset function returned undefined.

Issue 2: Multiple Thumbnail Requests

The page kept making repeated requests to generate thumbnails for sessions. This was due to the lack of memoization for the session object, resulting in unnecessary network calls.

Resolution and Recovery

Remove the if statement

Lessons Learned

  1. Carefully review the impact of new conditional logic on page rendering.
  2. Optimize API calls to avoid unnecessary network requests.
  3. Use memoization techniques like useMemo to improve performance.

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
streameth-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 10:09am

@greatsamist greatsamist requested a review from Mario-SO August 7, 2024 09:22
@greatsamist greatsamist self-assigned this Aug 7, 2024
@greatsamist greatsamist added the bug Something isn't working label Aug 7, 2024
@xannyxs
Copy link
Contributor

xannyxs commented Aug 7, 2024

@greatsamist would you be able to run prettier please

@greatsamist greatsamist merged commit f38bbcc into develop Aug 7, 2024
3 of 4 checks passed
@greatsamist greatsamist deleted the fix-broken-clip-page branch August 7, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants