🐛 hotfix: broken clip page and generate thumbnails repeated requests #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😵 Post-Mortem 😵
Summary
Impact
Root Cause Analysis
Issue 1: Broken Clip Page
An if statement was added to the Clip page, causing it to return a "not found" page when previewId was missing in the search params or when the previewAsset function returned undefined.
Issue 2: Multiple Thumbnail Requests
The page kept making repeated requests to generate thumbnails for sessions. This was due to the lack of memoization for the session object, resulting in unnecessary network calls.
Resolution and Recovery
Remove the if statement
Lessons Learned