Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Fix #807 - Improve the user onboarding experience #824

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

greatsamist
Copy link
Contributor

@greatsamist greatsamist commented Jul 29, 2024

Pull Request Info

Description

This PR enhances user onboarding by disabling account creation for new users on the login screen, updating the event onboarding page to offer options to either create an event or explore, and modifying the login screen to allow existing users to log in normally while presenting new users with a modal with a create event button that initiates the account creation flow.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots

image image

@greatsamist greatsamist linked an issue Jul 29, 2024 that may be closed by this pull request
8 tasks
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
streameth-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 3:25pm

@pblvrt
Copy link
Contributor

pblvrt commented Jul 30, 2024

LGTM, but when I try to login with a non existing account I get this:
Screenshot 2024-07-30 at 17 58 06

tried both email and metamask

@Mario-SO
Copy link
Member

LGTM, but when I try to login with a non existing account I get this:

Screenshot 2024-07-30 at 17 58 06

tried both email and metamask

I was going to improve a bit the modal that appears when a user is not found. Today around 7-8 pm i will arrive home and will work on this a bit.

@pblvrt
Copy link
Contributor

pblvrt commented Jul 30, 2024

ok but really need this in prod today @Mario-SO

@Mario-SO
Copy link
Member

ok but really need this in prod today @Mario-SO

🥲

@Mario-SO
Copy link
Member

Am I doing something wrong?

CleanShot.2024-07-30.at.15.00.02.mp4

I just sign in with rainbow as usual, but then I get redirected back to the sign in screen

@Mario-SO
Copy link
Member

New No user found dialog

CleanShot 2024-07-30 at 17 01 04@2x

@greatsamist
Copy link
Contributor Author

New modal LGTM

@Mario-SO Mario-SO merged commit 9ca8ba5 into develop Jul 30, 2024
3 of 4 checks passed
@greatsamist greatsamist deleted the 807-task-improve-the-user-onboarding-experience branch July 30, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Improve the user onboarding experience
3 participants