Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Twitter upload integration #823

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

Eric-Vondee
Copy link
Contributor

@Eric-Vondee Eric-Vondee commented Jul 26, 2024

Pull Request Info

Description

This pull request integrates the Twitter Media Upload API and Tweet API, enabling users to publish videos from the studio page to Twitter. The media upload process is divided into three phases:

  • Initialize: Send media type, command, and byte size to receive a media_id.
  • Append Phase: Split the video file into base64 chunks (≤ 5MB each) and send them to Twitter.
  • Finalize: Complete the media upload and process the video.

Closes (#782 )

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if appropriate):

Additional context:

Twitter's media upload limits apply:

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
streameth-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 0:19am

@Eric-Vondee Eric-Vondee marked this pull request as ready for review July 29, 2024 13:23
@Mario-SO
Copy link
Member

Mario-SO commented Jul 29, 2024

I will have to look at it more in depth on Wednesday because tomorrow I'm heading back home and it is a long trip.

Just as a side note, the button should have the (Coming soon) removed. I know this is frontend stuff, but it is quite trivial to change.

CleanShot 2024-07-29 at 22 45 43@2x

I got this too, which is weird... Just spin up the frontend and server, and when getting to /studio that popped up. You could still use the platform though.

CleanShot 2024-07-29 at 22 51 34@2x

When clicking in the Publish to twitter button and wanting to add a new destination (which by the way, the destinations tab on the side panel is no longer there) It properly redirected me to twitter but this appeared.

CleanShot 2024-07-29 at 22 54 31@2x

@Mario-SO Mario-SO added the enhancement New feature or request label Jul 29, 2024
@pblvrt
Copy link
Contributor

pblvrt commented Jul 30, 2024

@Mario-SO and @greatsamist align for testing

@Mario-SO Mario-SO linked an issue Aug 1, 2024 that may be closed by this pull request
9 tasks
@Eric-Vondee Eric-Vondee marked this pull request as draft August 5, 2024 10:08
@greatsamist greatsamist marked this pull request as ready for review August 6, 2024 10:17
@greatsamist greatsamist requested a review from Mario-SO August 6, 2024 10:17
@greatsamist
Copy link
Contributor

image

@greatsamist greatsamist removed the request for review from Mario-SO August 6, 2024 12:13
@greatsamist greatsamist merged commit 163471b into develop Aug 6, 2024
3 of 4 checks passed
@greatsamist greatsamist deleted the twitter-upload-integration branch August 6, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Integrate X API for content upload
4 participants