Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes #818 #819

Conversation

Mario-SO
Copy link
Member

@Mario-SO Mario-SO commented Jul 25, 2024

Pull Request Info

Description

In PR #814 I introduced a bug where when delting the banner and updating the organization, i was sending null instead of ' ' to the backend, and null is not supported on our organization schema (which makes total sense)

Fixes (#818)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if appropriate):

CleanShot.2024-07-25.at.17.35.10.1.mp4

Additional context:

closes #818

@Mario-SO Mario-SO added the medium priority You can have some sleep label Jul 25, 2024
@Mario-SO Mario-SO self-assigned this Jul 25, 2024
Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
streameth-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 3:44pm

@Mario-SO Mario-SO merged commit 4f1a8be into develop Jul 26, 2024
4 checks passed
@Mario-SO Mario-SO deleted the 818-bug-in-organization-settings-page-you-cant-remove-an-image-once-uploaded branch August 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority You can have some sleep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] In organization settings page, you can't remove an image once uploaded
2 participants