fix(egress-tracking): new partition and sort key for dynamo table #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
commented
Nov 22, 2024
| @@ -5,7 +5,7 @@ | |||
| "packageManager": "[email protected]+sha256.c8c61ba0fa0ab3b5120efd5ba97fdaf0e0b495eef647a97c4413919eda0a878b", | |||
| "type": "module", | |||
| "scripts": { | |||
| "start": "sst start", | |||
| "start": "sst dev", | |||
There was a problem hiding this comment.
The sst start command is deprecated.
View stack outputs
|
travis
approved these changes
Nov 22, 2024
fforbeck
added a commit
to storacha/freeway
that referenced
this pull request
Nov 25, 2024
Added the `nonce` as suggested per @alanshaw, but also set it to not expire, so we can process the invocation any time. The `servedAt` field doesn't need to be converted to seconds. Blocked by storacha/w3infra#443 & storacha/w3up#1588
alanshaw
reviewed
Nov 25, 2024
| @@ -191,7 +191,7 @@ export const createEgressTrafficTestContext = async () => { | |||
| }) | |||
| } | |||
|
|
|||
| const egressTrafficTable = await createTable(awsServices.dynamo.client, egressTrafficTableProps, 'egress-traffic-') | |||
| const egressTrafficTable = await createTable(awsServices.dynamo.client, egressTrafficTableProps, 'egress-traffic-events-') | |||
There was a problem hiding this comment.
This is how tables and queue names are defined in the test context. Then it adds some random value at the end for each time you execute the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I've identified an issue in our DynamoDB table where egress events were not being stored correctly. This was traced back to the configuration of our partition key (PK) and sort key (SK). In DynamoDB, the partition key is crucial for uniquely identifying each item, while the sort key helps organize data within a partition.
This change ensures that the combination of partition key and sort key is unique for each record, preventing DynamoDB from overriding existing records in case of a collision.
Changes Made
Modification of Partition Key (PK) & Sort Key (SK):
Inclusion of
causein Stripe Idempotent Key:causeas part of the Stripe idempotent key to ensure the uniqueness of requests to Stripe, preventing duplicate processing.Renaming of Table from
egress-traffictoegress-traffic-events:Impact
Blocked by storacha/w3up#1588