fix: deal time monitor aggregate threshold verification #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in monitoring code. Basically condition was preventing everything from getting fired. Details follow
We have 3 main variables:
With these variables we do:
AGGREGATE_MONITOR_THRESHOLD_MS
pendingwe were failing on step 2, and doing the comparison the other way around. So, we would filter out the aggregates that we should actually inspect. The aggregates that we would analyse were the ones that actually were recent, and therefore no alerts