Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #25. #26

Merged
merged 82 commits into from
Feb 4, 2024
Merged

Fixes Issue #25. #26

merged 82 commits into from
Feb 4, 2024

Conversation

rchatterjee
Copy link
Collaborator

The parsing of Android dumpsys logs were wrong. This is crashing the app sometime.

Next plan to make the historical scan viewable on the app. I am still working on that part.

@rchatterjee
Copy link
Collaborator Author

@lanamorgan @shffrror @tomrist The offline viewing works.
The main changes are:
(a) Fixing some bugs with the parsing of android dumps.
(b) Tested only on Android (Pixel 4 and Moto X). Need to test for iOS for the offline viewing, but it should not affect the online viewing (🤞).
(c) Next TODO would be to actually integrate these offline viewing with the testing framework.

@shffrror
Copy link
Collaborator

shffrror commented May 25, 2022

@rchatterjee I am unable to get the PR to build, receiving this error AttributeError: 'NoneType' object has no attribute 'device_info' on phone_scanner.py:489. Sorry that it took me a bit to get to it but I'll try to dig in deeper soon.

stehf and others added 28 commits February 3, 2024 23:59
Include step to install Fuse on macOS via Homebrew (ifuse repo doesn't include macOS install steps yet)
Also removed certain scripts that we will not need for the functionality of ISDi.
Fix depency issue stopipv#38
With all requirements satisfied, running isdi was crashing with:

```
Traceback (most recent call last):
  File "/home/fadelkon/git/isdi/./isdi", line 9, in <module>
    from web import app, sa
  File "/home/fadelkon/git/isdi/web/__init__.py", line 17, in <module>
    sa=SQLAlchemy(app)
  File "/home/fadelkon/git/isdi/venv/lib/python3.9/site-packages/flask_sqlalchemy/__init__.py", line 715, in __init__
    self.session = self.create_scoped_session(session_options)
  File "/home/fadelkon/git/isdi/venv/lib/python3.9/site-packages/flask_sqlalchemy/__init__.py", line 748, in create_scoped_session
    scopefunc = options.pop('scopefunc', _app_ctx_stack.__ident_func__)
AttributeError: 'LocalStack' object has no attribute '__ident_func__'
```
Bumps [flask](https://github.com/pallets/flask) from 2.2.2 to 2.2.5.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst)
- [Commits](pallets/flask@2.2.2...2.2.5)

---
updated-dependencies:
- dependency-name: flask
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [werkzeug](https://github.com/pallets/werkzeug) from 2.2.2 to 2.3.8.
- [Release notes](https://github.com/pallets/werkzeug/releases)
- [Changelog](https://github.com/pallets/werkzeug/blob/main/CHANGES.rst)
- [Commits](pallets/werkzeug@2.2.2...2.3.8)

---
updated-dependencies:
- dependency-name: werkzeug
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jinja2](https://github.com/pallets/jinja) from 3.1.2 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.1.2...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@rchatterjee rchatterjee merged commit c8ff65c into stopipv:main Feb 4, 2024
1 of 2 checks passed
@rchatterjee rchatterjee deleted the rahul-dev branch February 4, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants