ACM-5994 Clear cache and catch update error

[o-farag]

Description of the change(s):

• Clear cache and return err on failed deployment update

Why do we need this PR:

• Failed deployment update error may fall through and not reinstall with correct arguments. Catch error and clear cache

Issue reference:

• https://issues.redhat.com/browse/ACM-5994

Test API/Unit - Success

?       github.com/stolostron/hypershift-addon-operator/cmd     [no test files]
ok      github.com/stolostron/hypershift-addon-operator/pkg/agent       12.513s coverage: 71.3% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/install     175.386s        coverage: 84.9% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/manager     120.042s        coverage: 60.6% of statements
ok      github.com/stolostron/hypershift-addon-operator/pkg/metrics     0.006s  coverage: 100.0% of statements
?       github.com/stolostron/hypershift-addon-operator/pkg/util        [no test files]

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: o-farag
Once this PR has been reviewed and has the lgtm label, please assign zhujian7 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[o-farag]

/test all

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[rokej]

When we clear cache here, should we also remove locally saved secrets and configmaps as well?

[o-farag]

I don't think we need to remove them. Having a mismatch between the cache and locally saved secrets should cause a reconcile, and https://github.com/o-farag/hypershift-addon-operator/blob/c891a92db4f12cb78a4d454f3bf77a058ca23854/pkg/install/hypershift.go#L552 will update the secrets if anything changes

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.