Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove certificate-authority-data if HC has named certs #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philipwu08
Copy link
Contributor

Description of the change(s):

  • Remove certificate-authority-data from the admin-kubeconfig on the hub if the hosted cluster has serving certificates.

Why do we need this PR:

  • Workaround issue where the serving certificate is replaced by a generated self-signed cert.

Issue reference:

Test API/Unit - Success

ok  	github.com/stolostron/hypershift-addon-operator/pkg/agent	19.640s	coverage: 72.5% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/install	280.989s	coverage: 87.0% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/manager	1.114s	coverage: 55.8% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/metrics	0.584s	coverage: 100.0% of statements

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: philipwu08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

78.3% 78.3% Coverage
0.0% 0.0% Duplication

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants