-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACM-10996] Fixed credential config for auto-import secret #239
[ACM-10996] Fixed credential config for auto-import secret #239
Conversation
Signed-off-by: Disaiah Bennett <[email protected]>
/override "KinD tests (1.21, latest)" |
@dislbenn: Overrode contexts on behalf of dislbenn: KinD tests (1.21, latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Disaiah Bennett <[email protected]>
|
/override "KinD tests (1.21, latest)" |
@dislbenn: Overrode contexts on behalf of dislbenn: KinD tests (1.21, latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dislbenn, ngraham20 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5d100eb
into
stolostron:main
Description
Currently, we are fetching the
discoveryconfig
credential based on thediscoveryconfig
that is reconciled. This is leading to the wrong credential being used for the importeddiscoveredcluster
. This PR will look for thesecret
associated with thediscoveredcluster
resource.Related Issue
https://issues.redhat.com/browse/ACM-10996
Changes Made
Update secret flow from getting
discoveryconfig.spec.credential
todiscoveredcluster.spec.credential
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist
Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line:
/cc @reviewer1 @reviewer2
/cc @cameronmwall @ngraham20
Definition of Done