Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destructure pattern parser #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jfmengels
Copy link
Collaborator

In breaking-changes-v8, we have a separate type and parser for parser destructure patterns. I figured we could backport it to master without changing the type.

A benefit of having this already in the master branch is that rebase of the v8 branch will be smaller too, and we can continue to improve the performance of it until v8 lands.

I've updated it over successive rebases to resemble the regular Pattern parser, so it should have similar performance, or actually faster since it tries less things. My gut feeling says that this should therefore be faster, but in practice I measure a 1 to 3% performance decrease (using find-regressions), which I find surprising. Maybe it's not run enough times and therefore the JIT doesn't optimize as much or enough? 🤔

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant