Rework the Module type to grant access to common fields more easily #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfmengels
force-pushed
the
module-type
branch
2 times, most recently
from
25cba51 to
831e5c5
Compare
jfmengels
force-pushed
the
breaking-changes-v8
branch
from
eff82e1 to
0f43132
Compare
jfmengels
force-pushed
the
breaking-changes-v8
branch
2 times, most recently
from
7ccc635 to
1787a7f
Compare
jfmengels
force-pushed
the
module-type
branch
from
831e5c5 to
7ab96e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a lot easier to use, especially for the common case, without the need for all the helper functions (which have therefore been removed).