Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) InvoiceDescriptor23CIIWriter: rules fixes and simplifications #577

Merged
merged 4 commits into from
Jan 13, 2025
Merged

(chore) InvoiceDescriptor23CIIWriter: rules fixes and simplifications #577

merged 4 commits into from
Jan 13, 2025

Conversation

tobitege
Copy link
Contributor

@tobitege tobitege commented Jan 11, 2025 •
edited
Loading

InvoiceDescriptor23CIIWriter:

  • Fixed couple of rules within ApplicableHeaderTradeSettlement (removed XRechnung from Extended-only elements)
  • Introduced (for convenience) an often used profile shorthand PROFILE_COMF_EXT_XRG (23 times) to reduce code
  • Added more BT-xx inline comments (helps a lot whilst having documentation on the side)
  • Simplified several rules

stephanstapel
stephanstapel requested changes Jan 13, 2025
View reviewed changes
Copy link
Owner

@stephanstapel stephanstapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename the constant to:
PROFILE_COMFORT_EXTENDED_XRECHNUNG

@tobitege
Copy link
Contributor Author

please rename the constant to: PROFILE_COMFORT_EXTENDED_XRECHNUNG

Done 😃

@stephanstapel stephanstapel merged commit fe4ea5b into stephanstapel:master Jan 13, 2025
2 checks passed
@tobitege tobitege deleted the small-rule-fixes branch January 13, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanstapel stephanstapel stephanstapel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobitege @stephanstapel