Merge pull request #236 from drocx/feature/xrechnung_v3_warnings

If the ram:ID is not set for the Seller or Buyer Party, an empty tag is no longer written
stephanstapel · Feb 17, 2024 · 27e2bd5 · 27e2bd5
2 parents e5e0c5c + db7b58d
commit 27e2bd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/ZUGFeRD/InvoiceDescriptor.cs b/ZUGFeRD/InvoiceDescriptor.cs
@@ -480,7 +480,7 @@ public void AddNote(string note, SubjectCodes subjectCode = SubjectCodes.Unknown
         } // !AddNote()        
 
 
-        public void SetBuyer(string name, string postcode, string city, string street, CountryCodes country, string id,
+        public void SetBuyer(string name, string postcode, string city, string street, CountryCodes country, string id = null,
             GlobalID globalID = null, string receiver = "", LegalOrganization legalOrganization = null)
         {
             this.Buyer = new Party()
@@ -498,7 +498,7 @@ public void SetBuyer(string name, string postcode, string city, string street, C
         }
 
 
-        public void SetSeller(string name, string postcode, string city, string street, CountryCodes country, string id,
+        public void SetSeller(string name, string postcode, string city, string street, CountryCodes country, string id = null,
             GlobalID globalID = null, LegalOrganization legalOrganization = null)
         {
             this.Seller = new Party()

diff --git a/ZUGFeRD/InvoiceDescriptor21Writer.cs b/ZUGFeRD/InvoiceDescriptor21Writer.cs
@@ -1348,7 +1348,7 @@ private void _writeOptionalParty(ProfileAwareXmlTextWriter writer, PartyTypes pa
                         writer.WriteValue(party.ID.ID);
                         writer.WriteEndElement();
                     }
-                    else
+                    else if (!String.IsNullOrEmpty(party.ID.ID))
                     {
                         writer.WriteElementString("ram:ID", party.ID.ID);
                     }