Fix CRD import issue with oneOf, not, and anyOf
#424
Conversation
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
24a8801 to
42fb187
Compare
cmd/timoni/testdata/crd/golden/cue.mod/gen/flagger.app/alertprovider/v1beta1/types_gen.cue
Show resolved
Hide resolved
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
42fb187 to
0532660
Compare
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
0532660 to
dd63ac3
Compare
|
Adding a bump for gomega, as it gets only a shy +1 as part of CUE bump, might as well get the very latest. |
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
10b8da8 to
64bc1d2
Compare
There was a problem hiding this comment.
Thanks @errordeveloper! Really happy to see the CRD import working for oneOf/anyOf 🎉
go.mod
Outdated
| @@ -3,7 +3,7 @@ module github.com/stefanprodan/timoni | |||
| go 1.22.0 | |||
|
|
|||
| require ( | |||
| cuelang.org/go v0.9.2 | |||
| cuelang.org/go v0.11.0-alpha.1.0.20240910060539-63413629e06b | |||
There was a problem hiding this comment.
We'll need to wait for v0.11.0 to go GA before merging.
There was a problem hiding this comment.
Yes... only if one could use build tags in 'go.mod'!
|
Should we add test cases for all verbs? I think Flagger CRD has only one of them. |
|
v0.11.0 is out so we can move forward with this PR https://github.com/cue-lang/cue/releases/tag/v0.11.0 |
|
Just did a quick bump, let's see if CI is happy, will rebase then.
…On Tue, 19 Nov 2024 at 20:50, Stefan Prodan ***@***.***> wrote:
v0.11.0 is out so we can move forward with this PR
https://github.com/cue-lang/cue/releases/tag/v0.11.0
—
Reply to this email directly, view it on GitHub
<#424 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5MSZJHD6H63GWK6LXIOL2BOQABAVCNFSM6AAAAABN6SCNAOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBWG4ZDIOJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@errordeveloper I don't think CI would run if the PR has conflicts, but you can run it locally with |
curl --location --silent \ https://raw.githubusercontent.com/fluxcd/flagger/v1.38.0/artifacts/flagger/crd.yaml \ --output flagger.crds.yaml
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
7912fd4 to
4772c9c
Compare
errordeveloper
force-pushed
the
test-cue-cr-1200526
branch
from
25e4db3 to
2654799
Compare
|
@stefanprodan tests are passing now now, please have a look over the changes, I cannot be too sure of what some of the CUE changes in tests amount to, clearly a few things have changes in 0.11.0. |
stefanprodan
changed the title
oneOf, not, and anyOf
CUE now has resolved the CRD import issue with
oneOf,not, andanyOf(#336) as well required fields. This PR integrates latest revision and updates tests.Fix: #336