Change from allSettled to all for promises

stefanleminh · Feb 17, 2024 · e0b5583 · e0b5583
1 parent 8e2e3b3
commit e0b5583
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/commands/clear.ts b/src/commands/clear.ts
@@ -52,7 +52,7 @@ export const command: Command = {
     )
 
     await properties.guaranteedPlayersNextRoundIds.set(interaction.guild.id, [])
-    await Promise.allSettled(promises)
+    await Promise.all(promises)
     logger.debug('Cleared data and roles from participants!')
     await interaction.editReply(
       'I cleared all data and roles from participants!'

diff --git a/src/commands/endmatch.ts b/src/commands/endmatch.ts
@@ -55,8 +55,9 @@ export const command: Command = {
       })
     }
 
-    await Promise.allSettled(clearTeamRoles(interaction.guild.roles.cache, firstTeamRoleId, secondTeamRoleId))
-    await Promise.allSettled(promises)
+    const clearTeamRolesPromise = await Promise.all(clearTeamRoles(interaction.guild.roles.cache, firstTeamRoleId, secondTeamRoleId))
+    logger.info(JSON.stringify(clearTeamRolesPromise))
+    await Promise.all(promises)
     await interaction.editReply('GG!')
   }
 }
diff --git a/src/commands/endsession.ts b/src/commands/endsession.ts
@@ -38,7 +38,7 @@ export const command: Command = {
       properties.guaranteedPlayersNextRoundIds.delete(interaction.guild.id)
     )
 
-    await Promise.allSettled(promises)
+    await Promise.all(promises)
     logger.debug('Session ended! Cleared all data.')
 
     await interaction.reply('I ended the session and cleared all data.')

diff --git a/src/commands/randomize.ts b/src/commands/randomize.ts
@@ -29,7 +29,7 @@ export const command: Command = {
     ])
 
     const roles = await interaction.guild.roles.fetch()
-    await Promise.allSettled(
+    await Promise.all(
       clearTeamRoles(roles, firstTeamRoleId, secondTeamRoleId)
     )
 
@@ -68,7 +68,7 @@ export const command: Command = {
       )
     }
     const randomizedPlayerPool = shuffle(playerPool)
-    await Promise.allSettled(
+    await Promise.all(
       createTeams(randomizedPlayerPool, firstTeamRoleId, secondTeamRoleId)
     )
 

diff --git a/src/commands/startmatch.ts b/src/commands/startmatch.ts
@@ -54,7 +54,7 @@ export const command: Command = {
       const member = interaction.guild!.members.cache.get(player.id)!
       promises.push(setVoiceChannel(member, secondTeamVcId, interaction))
     })
-    await Promise.allSettled(promises)
+    await Promise.all(promises)
     await interaction.editReply('GLHF!')
   }
 }