Revert "Replace cache calls with actual fetches"

This reverts commit afa137a.
stefanleminh · Jun 17, 2023 · 0f622d0 · 0f622d0
1 parent afa137a
commit 0f622d0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/src/commands/listteams.ts b/src/commands/listteams.ts
@@ -20,10 +20,6 @@ export const command: Command = {
     if (interaction.guild == null) return
     if (!interaction.deferred) await interaction.deferReply()
 
-    // Update cache with new roles
-    await interaction.guild.members.fetch({ force: true })
-    await interaction.guild.roles.fetch()
-
     const [firstTeamRoleId, secondTeamRoleId, spectatorRoleId] = await Promise.all([
       properties.firstTeamRoleIds.get(interaction.guild.id),
       properties.secondTeamRoleIds.get(interaction.guild.id),
@@ -34,8 +30,10 @@ export const command: Command = {
       properties.firstTeamVcs.get(interaction.guild.id),
       properties.secondTeamVcs.get(interaction.guild.id)
     ])
-
-    const lobbyVcMembers: Collection<string, GuildMember> = (await interaction.guild.channels.fetch()).get(lobbyVcId)!.members.filter(member => !member.user.bot)
+    const lobbyVcMembers: Collection<string, GuildMember> = (interaction.guild.channels.cache
+      .get(lobbyVcId)!
+      .members as Collection<string, GuildMember>)
+      .filter(member => !member.user.bot)
     const embeds = createTeamEmbeds(lobbyVcMembers, firstTeamRoleId, secondTeamRoleId, spectatorRoleId, interaction.guild, firstTeamVcId, secondTeamVcId, lobbyVcId)
     await interaction.editReply({ embeds })
   }

diff --git a/src/commands/randomize.ts b/src/commands/randomize.ts
@@ -72,6 +72,9 @@ export const command: Command = {
       createTeams(randomizedPlayerPool, firstTeamRoleId, secondTeamRoleId)
     )
 
+    // Update cache with new roles
+    await interaction.guild.members.fetch()
+
     logger.info('==========randomize end==========')
 
     await listTeams.command.execute(interaction, properties)