Publish tree migrations under their own tag #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
The only issue i can think of will be that it would create a migration for collections and then another for navs if you do it later due to how migrationPath() works. I wonder if we should take the chance to switch to a more conventional migrations approach and have them with fixed dates? |
Yeah, I think that might be a better approach. It's the way Laravel handles it with their first-party packages. I'll close this PR and make that change in a separate PR. |
duncanmcclean
added a commit
to statamic/cms
that referenced
this pull request
Mar 6, 2024
Goes alongside statamic/eloquent-driver#250 This commit also adds a check around tree migration publishing so the migration is only published if a `tree` table doesn't already exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the migration for the
treestable to its own publish tag, to allow for it to be published independently of thenavigationstable.This PR also renames the migration to simply
create_trees_tablesince the table is calledtreesand notnavigation_trees. Feel free to rename this back if you think it'll cause issues.Builds on the changes introduced in #249.