[4.x] Fix Starter Kit installation on Windows #9968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #9967
If we run a command that doesn't actually install the Stater Kit, we will end up with the
Starter kit config [starter-kit.yaml] does not exist.error when installing usingphp please starter-kit:installdirectly, and is one of the ways to trigger theThere was a problem installing...error when using the Statamic CLI.The
where composercommand can return multiple results, which this PR handles. Additionally, since we are eventually passing this all to PHP, we need to look for thecomposer.pharfile, as the results will often point to either acomposer.batfile, or acomposerfile which often internally invokes PHP with thecomposer.pharfile.