Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Fix single unpublished entries in listing column #9917

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

jacksleight
Copy link
Contributor

@jacksleight jacksleight commented Apr 17, 2024

This bug #4251 still exists for single (max_items: 1) entries fields, as in that situation the query is still being run in the augment method which doesn't call whereAnyStatus.

This PR fixes it by breaking the query out into it's own method so that getItemsForPreProcessIndex can use that rather than relying on the return value of augment.

Screenshot 2024-04-17 at 14 22 07

@jasonvarga jasonvarga merged commit ba6d515 into statamic:4.x Apr 17, 2024
18 checks passed
@jacksleight jacksleight deleted the fix/single-unpublished-entry branch April 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants