Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Make Link field arrayable #8911

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

edalzell
Copy link
Contributor

@edalzell edalzell commented Nov 1, 2023

We use the Link fieldtype, and we often want to use the title of whatever we're linking to. Right now the link field augments to the url so the title is lost.

This change makes the field "arrayable" so you can now do {{ link_field:title }}.

@edalzell edalzell marked this pull request as ready for review November 2, 2023 18:13
@edalzell
Copy link
Contributor Author

edalzell commented Nov 2, 2023

The failing tests have to do with @firstChild, I'm not sure how to create an entry as a child in a test, so if you could show me I can update the rest.

@edalzell edalzell requested a review from jasonvarga November 2, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants