[5.x] fix(Terms): getCreatables()
throws an error if no user is authenticated.
#10232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This simple, one-character PR changes
src/Fieldtypes/Terms
so that it won't throw an error if no user is authenticated whengetCreatables()
is called.Why
I originally raised this issue in duncanmcclean/simple-commerce#1076. In brief, the shop / products page for my store failed to work for unauthenticated users after adding a taxonomy field to the blueprint for product variations.
This issue stems from a
Statamic\Fields\Field
class being created and themeta()
method being invoked on it.Whether this is a misuse of the framework, or a bug therein, I leave for you to decide.
Personally, I don't see the harm in allowing
getCreatables()
to work when no user is authenticated, but let me know if I'm wrong.I have an image here of the stack trace I encountered:
Let me know if there's anything else you need from me 😄