[5.x] Prevent user registration form from saving password_confirmation
#10228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
approved these changes
May 30, 2024
duncanmcclean
approved these changes
May 30, 2024
jasonvarga
approved these changes
May 30, 2024
jasonvarga
force-pushed
the
fix/dont-save-password-confirmation
branch
from
fbd0744 to
ba8024a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone reported on discord that the changes to the RegisterController / UserRegisterRequest have meant that the password_confirmation is being saved - in eloquent this causes issues as the column doesn't exist, and when file based this adds it to the yaml which it definitely shouldn't.
This PR updates the except in the form request to exclude it from being saved.