Collections are added as OR instead on AND in fetching entries from term query #10004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. Additionally, GitHub doesn't allow maintainer permissions from organization accounts. Please resubmit this PR from a personal GitHub account with maintainer permissions enabled. |
edalzell
reviewed
May 6, 2024
| $query->where('collection', $collection); | ||
| } | ||
| $query->where(function (Builder $query) { | ||
| foreach ($this->allowedCollections as $collection) { |
There was a problem hiding this comment.
Couldn't this be a whereIn?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the REST API endpoint for fetching entries connected to a term.
In the original code, the function checked the allowed, whitelisted collections and added that as a where per collection. When multiple collections where whitelisted in the api config. The query resulted in chained AND collection query like
collection = ? AND collection = ? AND collection = ?. The result is not fetching any entries at all and caused the json data array to be empty.