[5.x] Remove type attribute in nocache replacer (#11373)

* Remove script type attribute * Fix tests
statamic · Jan 21, 2025 · 1c4bd04 · 1c4bd04
1 parent b29a823
commit 1c4bd04
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/StaticCaching/Replacers/NoCacheReplacer.php b/src/StaticCaching/Replacers/NoCacheReplacer.php
@@ -104,7 +104,7 @@ private function insertJsInHead($contents, $cacher)
             Str::position($contents, '</head>'),
         ])->filter()->min();
 
-        $js = "<script type=\"text/javascript\">{$cacher->getNocacheJs()}</script>";
+        $js = "<script>{$cacher->getNocacheJs()}</script>";
 
         return Str::substrReplace($contents, $js, $insertBefore, 0);
     }
@@ -113,6 +113,6 @@ private function insertJsInBody($contents, $cacher)
     {
         $js = $cacher->getNocacheJs();
 
-        return str_replace('</body>', '<script type="text/javascript">'.$js.'</script></body>', $contents);
+        return str_replace('</body>', '<script>'.$js.'</script></body>', $contents);
     }
 }
diff --git a/tests/StaticCaching/FullMeasureStaticCachingTest.php b/tests/StaticCaching/FullMeasureStaticCachingTest.php
@@ -82,7 +82,7 @@ public function index()
         $this->assertEquals(vsprintf('<html><body>1 <span class="nocache" data-nocache="%s">%s</span>%s</body></html>', [
             $region->key(),
             '<svg>Loading...</svg>',
-            '<script type="text/javascript">js here</script>',
+            '<script>js here</script>',
         ]), file_get_contents($this->dir.'/about_.html'));
     }
 
@@ -154,7 +154,7 @@ public function it_should_add_the_javascript_if_there_is_a_csrf_token()
         // The cached response should have the token placeholder, and the javascript.
         $this->assertTrue(file_exists($this->dir.'/about_.html'));
         $this->assertEquals(vsprintf('<html><body>STATAMIC_CSRF_TOKEN%s</body></html>', [
-            '<script type="text/javascript">js here</script>',
+            '<script>js here</script>',
         ]), file_get_contents($this->dir.'/about_.html'));
     }
 }