Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): TE-2635 fix chart load issue on date change in alert details #1775

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

nalin-patidar
Copy link
Collaborator

Issue(s)

https://startree.atlassian.net/browse/TE-2635

Description

Chart data was not loading when user was updating the date range in alert details page.

Checklist

  • if queries to the database are changed: think about query performance and indexes

Screenshots

Attach screenshots of UI/UX changes, if applicable.

How to test

List steps to reproduce the issue(s) and test the change, if required.

@nalin-patidar nalin-patidar requested a review from a team as a code owner January 24, 2025 07:47
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:03pm

@github-actions github-actions bot added the thirdeye-ui Updates to thirdeye-ui project label Jan 24, 2025
@cyrilou242 cyrilou242 self-requested a review January 24, 2025 08:24
Copy link
Collaborator

@cyrilou242 cyrilou242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have at least 1 flow in the e2e tests for time picker usage ?
if possible all flows where a time picker is visible.

@nalin-patidar nalin-patidar merged commit aec90e0 into master Jan 24, 2025
13 of 14 checks passed
@nalin-patidar nalin-patidar deleted the te-2635 branch January 24, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thirdeye-ui Updates to thirdeye-ui project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants