Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): TE-2216 bug fixes for simple alert #1698

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Conversation

harshilvelotio
Copy link
Contributor

@harshilvelotio harshilvelotio commented Dec 1, 2024

Issue(s)

Issue 1
in dx --> sql query, configure notifications appear above the charts instead of below
Issue 2
let's remove the title here
this may mean the "json editor" will be moved to the row below. (not sure)
goal is to gain some vertical space 
Issue 3
"json editor" is not a json editor anymore
let's call it "VIEW JSON" for the moment
it may be ok to put it next to "add advanced options" for the moment
let's make sure the behavior is correct when the template is not selected yet. The button can be disabled, or it can show a modal with the config that was used for data preview, whatever is the simplest. 
Issue 4
in the JSON modal, remove cancel and apply changes. Just put a CLOSE button
Issue 5
I seem to remember we discussed having a dimension search bar in the dx case.

Description

Describe the changes being introduced.

Checklist

  • if queries to the database are changed: think about query performance and indexes

Screenshots

Attach screenshots of UI/UX changes, if applicable.

How to test

List steps to reproduce the issue(s) and test the change, if required.

@harshilvelotio harshilvelotio requested a review from a team as a code owner December 1, 2024 10:32
Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 11:41am

@github-actions github-actions bot added the thirdeye-ui Updates to thirdeye-ui project label Dec 1, 2024
@cyrilou242
Copy link
Collaborator

cyrilou242 commented Dec 4, 2024

Screenshot 2024-12-04 at 10 32 09

--> TO FIX: search dimensions at the bottom right corner

@cyrilou242
Copy link
Collaborator

cyrilou242 commented Dec 4, 2024

Screenshot 2024-12-04 at 10 34 06
--> this looks bad, please create a dedicated PR for this

especially when opened
Screenshot 2024-12-04 at 10 34 35

@nalin-patidar nalin-patidar merged commit 2c47749 into master Dec 5, 2024
14 checks passed
@nalin-patidar nalin-patidar deleted the TE-2216-1201 branch December 5, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thirdeye-ui Updates to thirdeye-ui project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants