[misc] enrich exception error logs with exception obj (#1659)

Co-authored-by: Anshul Singh <[email protected]>
startreedata · Nov 18, 2024 · b9ddc2b · b9ddc2b
1 parent 3ecb88d
commit b9ddc2b
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/thirdeye-core/src/main/java/ai/startree/thirdeye/datasource/cache/DataSourceCache.java b/thirdeye-core/src/main/java/ai/startree/thirdeye/datasource/cache/DataSourceCache.java
@@ -152,7 +152,7 @@ private void close(final ThirdEyeDataSource dataSource) {
     try {
       dataSource.close();
     } catch (final Exception e) {
-      LOG.error("Datasource {} was not flushed gracefully.", dataSource.getName());
+      LOG.error("Datasource {} was not flushed gracefully.", dataSource.getName(), e);
     }
   }
 

diff --git a/...e/src/main/java/ai/startree/thirdeye/detectionpipeline/operator/SqlExecutionOperator.java b/...e/src/main/java/ai/startree/thirdeye/detectionpipeline/operator/SqlExecutionOperator.java
@@ -103,7 +103,7 @@ private void initTables(final Connection connection) throws SQLException {
     try {
       dataTableToSqlAdapter.loadTables(connection, datatables);
     } catch (final SQLException e) {
-      LOG.error("Failed to load tables");
+      LOG.error("Failed to load tables", e);
       throw e;
     }
   }

diff --git a/.../src/main/java/ai/startree/thirdeye/plugins/datasource/pinot/PinotThirdEyeDataSource.java b/.../src/main/java/ai/startree/thirdeye/plugins/datasource/pinot/PinotThirdEyeDataSource.java
@@ -170,7 +170,7 @@ private ThirdEyeResultSetGroup executeSQL(final PinotQuery pinotQuery) throws Ex
       return thirdEyeResultSetGroup;
     } catch (final ExecutionException e) {
       LOG.error("Failed to execute SQL: {} with options {}", pinotQuery.getQuery(),
-          pinotQuery.getOptions());
+          pinotQuery.getOptions(), e);
       LOG.error("queryCache.stats: {}", queryCache.stats());
       throw e;
     }

diff --git a/...ye-plugins/thirdeye-pinot/src/main/java/org/apache/pinot/client/PinotConnectionUtils.java b/...ye-plugins/thirdeye-pinot/src/main/java/org/apache/pinot/client/PinotConnectionUtils.java
@@ -136,7 +136,7 @@ private static SSLContext httpsSslContext() {
           .build();
     } catch (final NoSuchAlgorithmException | KeyManagementException | KeyStoreException e) {
       // This section shouldn't happen because we use Accept All Strategy
-      LOG.error("Failed to generate SSL context for Pinot in https.");
+      LOG.error("Failed to generate SSL context for Pinot in https.", e);
       throw new RuntimeException(e);
     }
   }

diff --git a/thirdeye-scheduler/src/main/java/ai/startree/thirdeye/scheduler/DetectionCronScheduler.java b/thirdeye-scheduler/src/main/java/ai/startree/thirdeye/scheduler/DetectionCronScheduler.java
@@ -117,7 +117,7 @@ private void processAlert(final AlertDTO alert) {
         startJob(alert, detectionJob);
       }
     } catch (final Exception e) {
-      LOG.error("Error creating/updating job key for detection config {}", alert.getId());
+      LOG.error("Error creating/updating job key for detection config {}", alert.getId(), e);
     }
   }
 
@@ -136,7 +136,7 @@ private void processScheduledJobs() throws SchedulerException {
           stopJob(jobKey);
         }
       } catch (final Exception e) {
-        LOG.error("Error removing job key {}", jobKey);
+        LOG.error("Error removing job key {}", jobKey, e);
       }
     }
   }

diff --git a/thirdeye-server/src/main/java/ai/startree/thirdeye/service/AlertService.java b/thirdeye-server/src/main/java/ai/startree/thirdeye/service/AlertService.java
@@ -410,7 +410,8 @@ private long minimumLastTimestamp(final ThirdEyePrincipal principal, final Alert
       // replay from JAN 1 2000 because replaying from 1970 is too slow with small granularity
       LOG.error("Could not fetch insights for alert {}. Using the minimum time allowed. {}",
           dto,
-          minimumOnboardingStartTime);
+          minimumOnboardingStartTime,
+          e);
       return minimumOnboardingStartTime;
     }
   }