[core] Add guardrails to prevent same dataset from onboarding twice (#…

…1649) [core] Harden dataset persistence for uniqueness Co-authored-by: Anshul Singh <[email protected]>
startreedata · Nov 13, 2024 · a8bd117 · a8bd117
1 parent ead842f
commit a8bd117
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/thirdeye-core/src/main/java/ai/startree/thirdeye/datasource/DataSourceOnboarder.java b/thirdeye-core/src/main/java/ai/startree/thirdeye/datasource/DataSourceOnboarder.java
@@ -129,6 +129,11 @@ private DatasetConfigDTO persist(final DatasetConfigDTO datasetConfigDTO,
     final List<MetricConfigDTO> metrics = datasetConfigDTO.getMetrics();
     datasetConfigDTO.setAuth(auth);
     datasetConfigDTO.setMetrics(null);
+    final DatasetConfigDTO existingDatasetConfig = datasetConfigManager.findUniqueByNameAndNamespace(
+        datasetConfigDTO.getDataset(), datasetConfigDTO.namespace());
+    checkState(existingDatasetConfig == null,
+        "Dataset with name %s already exists in namespace %s",
+        datasetConfigDTO.getDataset(), datasetConfigDTO.namespace());
     final Long datasetId = datasetConfigManager.save(datasetConfigDTO);
     checkState(datasetId != null, "Failed creating dataset %s", datasetConfigDTO.getDataset());