-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove claimed_sum and LogupSums #979
base: 01-12-Logup_cumsum_constraint_with_cumsum_shift
Are you sure you want to change the base?
Remove claimed_sum and LogupSums #979
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 01-12-Logup_cumsum_constraint_with_cumsum_shift #979 +/- ##
===================================================================================
+ Coverage 92.02% 92.27% +0.25%
===================================================================================
Files 105 105
Lines 14274 14221 -53
Branches 14274 14221 -53
===================================================================================
- Hits 13135 13123 -12
+ Misses 1064 1024 -40
+ Partials 75 74 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 21 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
ec20bc8
to
bbbe8a7
Compare
9eb9411
to
d65de78
Compare
bbbe8a7
to
9e789d3
Compare
b1537e1
to
7b0dc24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 11 of 11 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
crates/prover/src/constraint_framework/info.rs
line 30 at r3 (raw file):
} impl InfoEvaluator { pub fn new(log_size: u32, preprocessed_columns: Vec<String>, total_sum: SecureField) -> Self {
isnt this a Gali change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
crates/prover/src/constraint_framework/info.rs
line 30 at r3 (raw file):
Previously, ohad-starkware (Ohad) wrote…
isnt this a Gali change?
I rebased over her change.
If you check r0->r3 the change is only on total_sum
9e789d3
to
3ca832e
Compare
7b0dc24
to
91ce246
Compare
No description provided.