Mix All Components Into Channel #350
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 409 at r1 (raw file):
pub fn mix_into(&self, channel: &mut impl Channel) { self.opcodes.mix_into(channel); self.memory_address_to_id.mix_into(channel);
Add also
self.verify_instruction.mix_into(channel);
Gali-StarkWare
force-pushed
the
gali/mix_into
branch
from
a294412 to
59677d3
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 409 at r1 (raw file):
Previously, shaharsamocha7 wrote…
Add also
self.verify_instruction.mix_into(channel);
Oops, done
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 409 at r1 (raw file):
Previously, Gali-StarkWare wrote…
Oops, done
can you do it in the same order as in claim::mix_into?
Gali-StarkWare
force-pushed
the
gali/mix_into
branch
from
59677d3 to
2f55b57
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ohad-starkware and @shaharsamocha7)
stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 409 at r1 (raw file):
Previously, shaharsamocha7 wrote…
can you do it in the same order as in claim::mix_into?
I did it according to the orders in CairoClaim and in CairoInteructionClaim respectively, which are different for some reason. I can do another PR for making them the same.
This change is