Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the names of jump opcodes #346

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ohad-nir-starkware
Copy link
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Jan 10, 2025

This change is Reviewable

@ohad-nir-starkware ohad-nir-starkware self-assigned this Jan 10, 2025
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/update-opcodes-names-jump_opcode branch 6 times, most recently from 639293f to 4747b00 Compare January 10, 2025 21:52
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/update-opcodes-names-jump_opcode branch from 4747b00 to 84bb6a3 Compare January 14, 2025 12:27
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 15 of 17 files at r1, all commit messages.
Reviewable status: 15 of 17 files reviewed, all discussions resolved (waiting on @DavidLevitGurevich and @shaharsamocha7)

Copy link
Collaborator Author

@ohad-nir-starkware ohad-nir-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DavidLevitGurevich and @shaharsamocha7)

@ohad-nir-starkware ohad-nir-starkware merged commit 714be60 into main Jan 14, 2025
7 checks passed
@ohad-nir-starkware ohad-nir-starkware deleted the ohadn/update-opcodes-names-jump_opcode branch January 14, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants