Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add and sub traits for StorageKey #163

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use std::fmt::Debug;

use indexmap::IndexMap;
use serde::{Deserialize, Serialize};
use starknet_crypto::FieldElement;

use crate::block::{BlockHash, BlockNumber};
use crate::core::{
Expand Down Expand Up @@ -147,6 +148,46 @@ impl From<u128> for StorageKey {

impl_from_through_intermediate!(u128, StorageKey, u8, u16, u32, u64);

impl std::ops::Add<i128> for StorageKey {
type Output = Self;

fn add(self, rhs: i128) -> Self::Output {
let offset = FieldElement::from(rhs.unsigned_abs());
let rhs = if rhs > 0 { offset } else { -offset };

let base_address = Into::<FieldElement>::into(*self.0.key()) + rhs;

StorageKey(
PatriciaKey::try_from(StarkFelt::from(base_address))
.expect("attempt to add to storage key with overflow"),
)
}
}

impl std::ops::Add<StorageKey> for i128 {
type Output = StorageKey;

fn add(self, rhs: StorageKey) -> Self::Output {
let offset = FieldElement::from(self.unsigned_abs());
let lhs = if self > 0 { offset } else { -offset };

let base_address = lhs + Into::<FieldElement>::into(*rhs.0.key());

StorageKey(
PatriciaKey::try_from(StarkFelt::from(base_address))
.expect("attempt to add to storage key with overflow"),
)
}
}

impl std::ops::Sub<i128> for StorageKey {
type Output = Self;

fn sub(self, rhs: i128) -> Self::Output {
self + (-rhs)
}
}

/// A contract class.
#[derive(Debug, Clone, Default, Eq, PartialEq, Deserialize, Serialize)]
pub struct ContractClass {
Expand Down
35 changes: 35 additions & 0 deletions src/state_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ use std::collections::HashMap;
use serde_json::json;

use crate::deprecated_contract_class::EntryPointOffset;
use crate::state::StorageKey;

#[test]
fn entry_point_offset_from_json_str() {
Expand All @@ -22,3 +23,37 @@ fn entry_point_offset_into_json_str() {
let offset = EntryPointOffset(123);
assert_eq!(json!(offset), json!(format!("{:#x}", offset.0)));
}

#[test]
fn offset_storage_key_add_rhs_ok() {
let key = StorageKey::from(123u128);
let offset = -23;
let expected = StorageKey::from(100u128);
let result: StorageKey = key + offset;
assert_eq!(expected, result);
}

#[test]
#[should_panic(expected = "attempt to add to storage key with overflow")]
fn offset_storage_key_add_rhs_err() {
let key = StorageKey::from(123u128);
let offset = -124;
let _: StorageKey = key + offset;
}

#[test]
fn offset_storage_key_add_lhs_ok() {
let key = StorageKey::from(123u128);
let offset = -23;
let expected = StorageKey::from(100u128);
let result: StorageKey = offset + key;
assert_eq!(expected, result);
}

#[test]
#[should_panic(expected = "attempt to add to storage key with overflow")]
fn offset_storage_key_add_lhs_err() {
let key = StorageKey::from(123u128);
let offset = -124;
let _: StorageKey = offset + key;
}