refactor(starknet_batcher): use InternalConsensusTransaction #3777
+372
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
noamsp-starkware
force-pushed
the
noam.s/refactor_starknet_batcher_use_InternalConsensusTransaction
branch
from
dd84510 to
07ee3aa
Compare
rename GetProposalContent to GetProposalContentDeprecated rename SendProposalContent to SendProposalContentDeprecated block builder convert internal to exe tx using class manager
noamsp-starkware
force-pushed
the
noam.s/refactor_starknet_batcher_use_InternalConsensusTransaction
branch
from
07ee3aa to
3af4883
Compare
alonh5
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Reviewed 1 of 13 files at r1, all commit messages.
Reviewable status: 1 of 13 files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware and @ShahakShama)
a discussion (no related file):
Talked to @ShahakShama offline. Blocking for now.
noamsp-starkware
deleted the
noam.s/refactor_starknet_batcher_use_InternalConsensusTransaction
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename GetProposalContent to GetProposalContentDeprecated
rename SendProposalContent to SendProposalContentDeprecated
block builder convert internal to exe tx using class manager