-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(starknet_integration_tests): use batched txs metric instead of account nonce #3761
base: yair/e2e_use_monitoring
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Yair - Auto-assign" took an action on this PR • (01/28/25)1 assignee was added to this PR based on Yair's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @yair-starkware)
crates/starknet_integration_tests/src/sequencer_manager.rs
line 294 at r1 (raw file):
.await .unwrap(); assert_eq!(n_batched_txs, expected_n_batched_tx);
Please add a message here
Code quote:
assert_eq!(n_batched_txs, expected_n_batched_tx);
21ec158
to
183d704
Compare
Artifacts upload workflows: |
183d704
to
9e2e2ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/sequencer_manager.rs
line 294 at r1 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Please add a message here
Done.
8f15f32
to
fe1e355
Compare
9e2e2ca
to
2d476e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_integration_tests/src/sequencer_manager.rs
line 116 at r3 (raw file):
} fn batcher_storage_reader(&self) -> StorageReader {
Yay!
fe1e355
to
ebfb4dc
Compare
2d476e7
to
bcaf85f
Compare
No description provided.