refactor(papyrus_rpc): change DeployAccountTransaction TryFrom func to From func #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 28, 2025
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/deploy-acount-from-func
branch
from
e267139 to
64f1cd4
Compare
ArniStarkware
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @alonh5)
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/v0_8/resource-bounds-mapping/add-l1-data-gas
branch
2 times, most recently
from
b0de396 to
eff335c
Compare
alonh5
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
ArniStarkware
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Reviewable status:
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/v0_8/resource-bounds-mapping/add-l1-data-gas
branch
from
eff335c to
1a3a091
Compare
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/deploy-acount-from-func
branch
from
64f1cd4 to
6bba820
Compare
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/v0_8/resource-bounds-mapping/add-l1-data-gas
branch
from
1a3a091 to
5a37b3c
Compare
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/deploy-acount-from-func
branch
from
6bba820 to
217a2db
Compare
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/v0_8/resource-bounds-mapping/add-l1-data-gas
branch
from
5a37b3c to
b4ea0ed
Compare
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/deploy-acount-from-func
branch
from
217a2db to
9da7bb0
Compare
ayeletstarkware
changed the base branch from
ayelet/papyrus_rpc/v0_8/resource-bounds-mapping/add-l1-data-gas
to
main
Merge activity
|
ArniStarkware
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Reviewable status:
ayeletstarkware
force-pushed
the
ayelet/papyrus_rpc/deploy-acount-from-func
branch
from
9da7bb0 to
0b86e2a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.