refactor(papyrus_protobuf): mv consensus.proto to new folder and add ConsensusTransaction #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlonLStarkWare
commented
Jan 27, 2025
AlonLStarkWare
commented
- refactor(papyrus_protobuf): add converters for new transaction messages
- refactor(papyrus_protobuf): move consensus.proto to a different folder and added ConsensusTransaction
AlonLStarkWare
requested review from
ShahakShama,
eitanm-starkware and
noamsp-starkware
|
This change is |
AlonLStarkWare
force-pushed
the
alonl/partial_alignment_of_consensus.proto
branch
from
8aa6971 to
9a17195
Compare
AlonLStarkWare
changed the title
AlonLStarkWare
force-pushed
the
alonl/partial_alignment_of_consensus.proto
branch
3 times, most recently
from
dbe2264 to
707cbfe
Compare
ShahakShama
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: 5 of 7 files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)
AlonLStarkWare
force-pushed
the
alonl/partial_alignment_of_consensus.proto
branch
2 times, most recently
from
e51fd70 to
2927196
Compare
…ConsensusTransaction
AlonLStarkWare
force-pushed
the
alonl/partial_alignment_of_consensus.proto
branch
from
2927196 to
967bd38
Compare
ShahakShama
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 46 of 46 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware and @noamsp-starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.